Skip to content

RATIS-1774. Change SenderList in LeaderStateImpl to implement Iterable.#813

Merged
codings-dan merged 3 commits into
apache:masterfrom
szetszwo:RATIS-1774
Jan 31, 2023
Merged

RATIS-1774. Change SenderList in LeaderStateImpl to implement Iterable.#813
codings-dan merged 3 commits into
apache:masterfrom
szetszwo:RATIS-1774

Conversation

@szetszwo
Copy link
Copy Markdown
Contributor

@szetszwo szetszwo changed the title RATIS-1774. Remove SenderList from LeaderStateImpl. RATIS-1774. Change SenderList in LeaderStateImpl to implement Iterable. Jan 23, 2023
Copy link
Copy Markdown
Member

@kaijchen kaijchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @szetszwo for the improvement.

@szetszwo szetszwo requested a review from codings-dan January 31, 2023 07:17
Copy link
Copy Markdown
Contributor

@codings-dan codings-dan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@szetszwo Thanks for working on this! the change looks good, +1

@codings-dan codings-dan merged commit 7626a7e into apache:master Jan 31, 2023
@szetszwo
Copy link
Copy Markdown
Contributor Author

@kaijchen , @codings-dan , thanks a lot for reviewing this!

szetszwo added a commit that referenced this pull request Mar 5, 2023
kuszz pushed a commit to kuszz/ratis that referenced this pull request Mar 7, 2023
…e. (apache#813)

* RATIS-1774. Change SenderList in LeaderStateImpl to implement Iterable.

* Remove checkAllProgress(..)

* Revert renaming getLogAppenders() to getSenders().
symious pushed a commit to symious/ratis that referenced this pull request Mar 14, 2024
…e. (apache#813)

* RATIS-1774. Change SenderList in LeaderStateImpl to implement Iterable.

* Remove checkAllProgress(..)

* Revert renaming getLogAppenders() to getSenders().
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants